Phase ids normalize 1.10 to 1.1 in seed-reqs and cursor set

john commented

2026-08-15 14:33:44 +00:00

Owner

Source: deep dive F10
Verdict: AGREE - already filed in .planning/CAPTURE.md

Claim as reviewed

Phase 1.10 becomes numeric 1.1, merging distinct phases in traceability and audit data. The system is split between raw-string and numeric identity, so correctness depends on which path a command happens to use.

At HEAD `f354864` (v3.3.0)

cadence-core/bin/planning.mjs:1801-1810 states the collision in the source and names it a known identity collision rather than an oversight. Two surviving sites: cmdSeedReqs' Traceability rows, and cmdCursorSet writing the numeric value.

Already tracked in-tree at .planning/CAPTURE.md:120 (phase 1, lease-check/cmdTrace) and :143 (phase 3, cmdSeedReqs/cmdCursorSet), the second naming both surviving sites and the reason it was scoped out.

Note

Filed here only so the review batch is complete. The close is what CAPTURE.md already describes: carry the raw spelling through parseCursor, renumber and audit, each of which consumes a Number today.

**Source:** deep dive F10 **Verdict:** AGREE - already filed in .planning/CAPTURE.md ### Claim as reviewed Phase `1.10` becomes numeric `1.1`, merging distinct phases in traceability and audit data. The system is split between raw-string and numeric identity, so correctness depends on which path a command happens to use. ### At HEAD f354864 (v3.3.0) `cadence-core/bin/planning.mjs:1801-1810` states the collision in the source and names it a known identity collision rather than an oversight. Two surviving sites: `cmdSeedReqs`' Traceability rows, and `cmdCursorSet` writing the numeric value. Already tracked in-tree at `.planning/CAPTURE.md:120` (phase 1, `lease-check`/`cmdTrace`) and `:143` (phase 3, `cmdSeedReqs`/`cmdCursorSet`), the second naming both surviving sites and the reason it was scoped out. ### Note Filed here only so the review batch is complete. The close is what CAPTURE.md already describes: carry the raw spelling through `parseCursor`, `renumber` and `audit`, each of which consumes a Number today.

john added the

bug

external-review

labels

2026-08-15 14:33:44 +00:00

john added this to the v3.5.6 milestone

2026-08-15 15:09:30 +00:00

john commented

2026-08-15 15:09:32 +00:00

Author

Owner

Already scoped in-tree - do not re-derive it. .planning/CAPTURE.md:143 names both surviving sites (cmdSeedReqs' Traceability rows, cmdCursorSet writing the numeric value), states the root cause, and names the three consumers that each take a Number today: renumber's shift arithmetic, cmdStatus' parsed.phase === current, and phase-plans.mjs' cursorPhase. CAPTURE.md:120 covers the lease-check/cmdTrace half. Start from those two entries.

john modified the milestone from v3.5.6 to v3.5.4

2026-08-18 10:23:29 +00:00

john modified the milestone from v3.5.4 to v3.5.5

2026-08-18 10:25:37 +00:00

john commented

2026-08-19 20:59:52 +00:00

Author

Owner

Closed by v3.5.5 (ARG-03, verified against the shipped tree).

john closed this issue

2026-08-19 20:59:56 +00:00