README/METHOD said plan review is advisory at shipped #148
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#148
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Source: strict re-review C-08 (reviewed against v3.2.0)
Verdict: FIXED in v3.3.0 - closing
Claim as reviewed
README and METHOD say shipped plan review is advisory while the route table says off, so an operator cannot rely on prose to know actual default review coverage.
At HEAD
f354864(v3.3.0)True when reviewed. Closed by v3.3.0, whose changelog names it directly: "
README.md,METHOD.mdandcadence-core/workflows/plan.mdstated aplanreview as advisory atshippedwhereroute-table.jsonresolvesoff".Current text agrees with the table:
README.md:56- "a plan review is advisory atsolo, off atshippedbecause an advisory gate blocks nothing, and adjudicated atcritical".METHOD.md:287and:308-310carry the same row.Note
The review targeted commit
81bdb5d4fcon the v3.2.0 tree, one milestone behind HEAD.