README's 'every push asks' claim overstates the git guard #150
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#150
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Source: strict re-review C-07
Verdict: DISPUTE - overstated, closing
Claim as reviewed
The README says "Every push it tries to run stops and asks you first" despite the documented invisible wrapper form, which is a false guarantee in operator documentation.
At HEAD
f354864(v3.3.0)README.md:30does carry that sentence. But the two carve-outs are disclosed within four lines of it, by hand:README.md:32- "every push the hook can see still asks".README.md:34- "bash -c \"git push\"is invisible, and that is written down rather than discovered ... in a hook that fails open".The mechanism limits themselves are real and tracked separately:
cadence-core/bin/lib/git-segments.mjs:74requires the command word to begit,:58-61lists the evasions, andcadence-core/bin/git-guard.mjs:211fails open deliberately.Note
The isolated sentence is loose. It is not an undisclosed claim, which is what the finding asserts. Reworded prose would be an improvement, not a defect fix - reopen as a
documentationissue if the wording is worth tightening on its own.