Reviewer set is not a hard dispatch invariant #156
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#156
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Source: strict re-review C-12
Verdict: DISPUTE - subsumed, closing
Claim as reviewed
Reviewer-set resolution detects and falls back rather than establishing an invariant that an out-of-set reviewer cannot execute, so review independence can degrade rather than fail closed.
At HEAD
f354864(v3.3.0)Accurate.
cadence-core/bin/route.mjs:630-636emitsreviewerson the resolve envelope as advice; the dispatch itself is performed by the orchestrating model followingreferences/review-triggers.md. Nothing prevents a dispatch the resolve did not sanction.Note
This is the same seam-advises / model-enforces shape as the
risk_surfacerecord issue, which is open and is the general form of the problem. Fixing observability there is what makes this one answerable.Closed as a duplicate in substance; reopen if the risk_surface work does not generalize.