Unstaged user edits can ride into an executor commit #158
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#158
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Source: strict re-review C-15
Verdict: DISPUTE - documented limit, closing
Claim as reviewed
Pre-existing unstaged user edits on a leased file can ride into an executor commit, so commit attribution is not guaranteed by a clean index.
At HEAD
f354864(v3.3.0)Accurate, and stated at the site in both directions.
cadence-core/workflows/execute.md:74-92: an unstaged edit to a declared path rides into the commit because staging a path stages its whole working-tree content, and an untracked file outside the lease that a latergit addsweeps in reads as a lease violation the executor never committed.The workflow also gives the remedy: "start it from a clean worktree (
git status --porcelainempty), not merely a clean index."Note
"The lease gate cannot separate them either: the path is declared, so the write is legal, and provenance is not a property of a path." Widening the check does not close it.