milestone-prune reads only the first physical line of a wrapped requirement bullet #179
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#179
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hit live at the v3.3.0, v3.4.1 and v3.5.0 closes. Both halves of the transform are wrong for the same reason, and it fires on every close because requirement bullets in this repo wrap by default.
## ActiveremovalIt removes each
- **ID**:lead line and leaves every continuation line behind. At the v3.3.0 close the section came back holding 43 lines of orphaned prose fragments with no bullet over them. At the v3.5.0 close it left this:## ShippedarchivalarchiveRequirementsbuilds each archived rows parenthetical summary from that same first line, so rows land truncated mid-sentence:Why it matters more than a formatting nit
lib/milestone-prune.mjss own header says these surgeries were made deterministic because every hand-performed version had "a recorded failure (a close that left the tree failing its own audit)". This is that exact failure class surviving inside the seam built to replace it, and it has now been hand-repaired at three consecutive closes.Fix
A bullet-span read - lead line plus the following indented continuation lines - in both
archiveRequirementsand the## Activeremoval, plus a fixture whose bullets wrap. The existing fixtures evidently do not.Fixed in
71ec570(fix(2-1): read the whole bullet span in both halves of archiveRequirements); shipped in v3.5.1.lib/milestone-prune.mjspulls the bullet's whole span rather than its lead line (D-01).