issue-check resolves the tracker by origin URL host, so an SSH-host remote never matches a tea login #180
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#180
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
LND-01 shipped in v3.4.0 to surface the tracker before work lands. On this repository - the one it was built in - it has never produced a report.
What happens
At the v3.5.0 land,
/cad-landstep 1 returned:Why
originisssh://git@ssh.jcrenshaw.dev:2222/crenshawdev/cadence.git, so the host parsed off the origin URL isssh.jcrenshaw.dev.tea login listholds:The login is keyed on the web host. Nothing matches, so the seam takes its skip arm - correctly, by its own contract, which is why this is invisible rather than loud.
A dedicated SSH host is a normal Forgejo/Gitea deployment shape (separate SSH endpoint, non-standard port), so this is not a local misconfiguration.
tea issues ls --repo crenshawdev/cadenceworks fine against the same login, which is how the v3.5.0 close read and closed #130 by hand.Fix shape
Resolve the login by repository rather than by URL-host string equality: consult
tea login listsSSH HOSTcolumn as well as the URL host, or fall through to the explicit--repo <owner>/<name>form the CLI already accepts and which already works here. Either way the degradation stays one line and read-only - the requirement is that a correctly configured Forgejo remote stops degrading silently, not that the skip arm goes away.Regression cover should include a remote whose SSH host differs from its web host.
Fixed in
fd42f87(fix(2-1): bind the forgejo call with --remote origin, not a login this file picked) plus20b6bd5and6df63e0; shipped in v3.5.1. The login inference inclassifyOriginis gone - the tea call binds to the checkout's remote instead.