Per-issue resolve bound is per call, not per land #181
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#181
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
From the phase 2 risk_surface review (medium, adjudicated survivor).
issue-check.mjsstops the resolve loop only when a call comes backtimedOut. Ateathat answers slowly and exits nonzero is never marked timed out, so each of the capped resolves can burn nearly the full call timeout. With the default bound and five unanswered references that is roughly five timeouts of latency on the land path, which is the multiplication the loop break was written to prevent.Fix direction: bound the resolve phase on total elapsed wall clock, not on a per-call flag.
Found in: cadence-core/bin/issue-check.mjs (the resolve loop after partitionIssues)
Fixed in v3.5.4 as ISS-01, merged in #217 and tagged v3.5.4. The fix carries a check watched failing against the unpatched tree first.