Per-issue resolve bound is per call, not per land #181

Closed
opened 2026-08-16 01:18:55 +00:00 by john · 1 comment
Owner

From the phase 2 risk_surface review (medium, adjudicated survivor).

issue-check.mjs stops the resolve loop only when a call comes back timedOut. A tea that answers slowly and exits nonzero is never marked timed out, so each of the capped resolves can burn nearly the full call timeout. With the default bound and five unanswered references that is roughly five timeouts of latency on the land path, which is the multiplication the loop break was written to prevent.

Fix direction: bound the resolve phase on total elapsed wall clock, not on a per-call flag.

Found in: cadence-core/bin/issue-check.mjs (the resolve loop after partitionIssues)

From the phase 2 risk_surface review (medium, adjudicated survivor). `issue-check.mjs` stops the resolve loop only when a call comes back `timedOut`. A `tea` that answers slowly and exits nonzero is never marked timed out, so each of the capped resolves can burn nearly the full call timeout. With the default bound and five unanswered references that is roughly five timeouts of latency on the land path, which is the multiplication the loop break was written to prevent. Fix direction: bound the resolve phase on total elapsed wall clock, not on a per-call flag. Found in: cadence-core/bin/issue-check.mjs (the resolve loop after partitionIssues)
john added this to the v3.5.4 milestone 2026-08-18 10:23:28 +00:00
Author
Owner

Fixed in v3.5.4 as ISS-01, merged in #217 and tagged v3.5.4. The fix carries a check watched failing against the unpatched tree first.

Fixed in v3.5.4 as ISS-01, merged in #217 and tagged v3.5.4. The fix carries a check watched failing against the unpatched tree first.
john closed this issue 2026-08-18 19:29:07 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: crenshawdev/cadence-archived#181
No description provided.