normalizeNumber accepts digit strings past the safe-integer range #182
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#182
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
From the phase 2 risk_surface review (medium, adjudicated survivor).
normalizeNumberconverts a digit string withNumber()and no safe-integer test, so two distinct issue indices can compare equal after precision loss. A resolve reading an index of 9007199254740993 against the referenced number 9007199254740992 matches, and the seam reports a state it read for a different issue.Contrived on a real tracker, but the seam is written to refuse affirmative answers about input it could not read, and this is one.
Found in: cadence-core/bin/lib/issue-decision.mjs (normalizeNumber)
Closed by v3.5.5 (ARG-04, verified against the shipped tree).