DRF-02: the interrupted-close exemption cannot hold for a blocked phase #211
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#211
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Requirement DRF-02, seeded at the v3.5.3 close.
The interrupted-close exemption in
/cad-auditisderivePhases(...).every(complete), butmilestone.mdsanctions closing a milestone with rolled-over work, and a UAT holding a terminalblockeditem can never derive complete (planning-files.mjs:1097).So
driftfires in exactly the stateaudit.mddeclares exempt, and the remedy it offers is oneverify.mdsays is impossible:blockedis terminal and nothing returns an item to the walk from it.Two fixtures exist from the v3.5.2 diff review (
planning.mjs:1007).Fix direction: the exemption tests whether a phase is ANSWERABLE, not whether it is Complete.
Fixed in v3.5.4 as DRF-02, merged in #217 and tagged v3.5.4. The fix carries a check watched failing against the unpatched tree first.