config.schema.json says phase_diff is advisory at shipped; route table says off #134
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
external-review
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
security
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence-archived#134
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Source: strict re-review C-10
Verdict: AGREE - medium
Claim as reviewed
The
phase_difftrigger's schema prose describes shipped behaviour that disagrees with the route table used by actual routing.At HEAD
f354864(v3.3.0)cadence-core/config.schema.json:80- "Leave it UNSET and the stakes level decides - off at solo, advisory at shipped, adjudicated at critical".cadence-core/route-table.jsonshipped row -"phase_diff": "off".Only the shipped word is wrong;
solo(off) andcritical(adjudicated) match.Note
Same root cause as the
config.mjs getissue: the schema is stating a default that routing does not honour. A prose assertion comparing every trigger's schema sentence to the table row would close both.Sequencing: #135 lands first in v3.4.1. Its assertion fails on the current tree, which proves this issue is real before it is touched, and its failure output enumerates the exact trigger rows to fix here. Do not plan this in parallel with #135 - this consumes its output. Full reasoning in the comment on #135.
Shipped in v3.4.1 (#177). https://git.jcrenshaw.dev/crenshawdev/cadence/releases/tag/v3.4.1