config.schema.json says phase_diff is advisory at shipped; route table says off #134

Closed
opened 2026-08-15 14:33:37 +00:00 by john · 2 comments
Owner

Source: strict re-review C-10
Verdict: AGREE - medium

Claim as reviewed

The phase_diff trigger's schema prose describes shipped behaviour that disagrees with the route table used by actual routing.

At HEAD f354864 (v3.3.0)

cadence-core/config.schema.json:80 - "Leave it UNSET and the stakes level decides - off at solo, advisory at shipped, adjudicated at critical".

cadence-core/route-table.json shipped row - "phase_diff": "off".

Only the shipped word is wrong; solo (off) and critical (adjudicated) match.

Note

Same root cause as the config.mjs get issue: the schema is stating a default that routing does not honour. A prose assertion comparing every trigger's schema sentence to the table row would close both.

**Source:** strict re-review C-10 **Verdict:** AGREE - medium ### Claim as reviewed The `phase_diff` trigger's schema prose describes shipped behaviour that disagrees with the route table used by actual routing. ### At HEAD f354864 (v3.3.0) `cadence-core/config.schema.json:80` - "Leave it UNSET and the stakes level decides - off at solo, advisory at shipped, adjudicated at critical". `cadence-core/route-table.json` shipped row - `"phase_diff": "off"`. Only the shipped word is wrong; `solo` (`off`) and `critical` (`adjudicated`) match. ### Note Same root cause as the `config.mjs get` issue: the schema is stating a default that routing does not honour. A prose assertion comparing every trigger's schema sentence to the table row would close both.
john added this to the v3.4.1 milestone 2026-08-15 15:01:08 +00:00
Author
Owner

Sequencing: #135 lands first in v3.4.1. Its assertion fails on the current tree, which proves this issue is real before it is touched, and its failure output enumerates the exact trigger rows to fix here. Do not plan this in parallel with #135 - this consumes its output. Full reasoning in the comment on #135.

Sequencing: #135 lands first in v3.4.1. Its assertion fails on the current tree, which proves this issue is real before it is touched, and its failure output enumerates the exact trigger rows to fix here. Do not plan this in parallel with #135 - this consumes its output. Full reasoning in the comment on #135.
Author
Owner
Shipped in v3.4.1 (#177). https://git.jcrenshaw.dev/crenshawdev/cadence/releases/tag/v3.4.1
john closed this issue 2026-08-15 19:54:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: crenshawdev/cadence-archived#134
No description provided.