test: skip the mode-bit arms when the runner is root #228

Merged

john merged 1 commit from fix/ci-root-mode-bits into main 2026-08-22 14:49:03 +00:00

Conversation 0 Commits 1 Files changed 1 +9 -3

john commented 2026-08-22 14:33:59 +00:00

Owner

Copy link

node-test (routing, 22) and (routing, 24) have been red on main since the
runner started executing as root. Three tests in
cadence-core/bin/phase-plans.test.mjs chmod a fixture to 0o000 and assert
that the unreadable plan or archive directory is skipped:

• an unreadable plan does the same: no path, one warning, clean below found
• the by-path reader carries the out-of-grammar and unreadable arms too
• an unreadable archive directory is skipped, never a throw

Root ignores mode bits, so on the runner the fixtures read back fine, the
"unreadable" plan parses, and all three assertions fail. Every local non-root
run is green, which is the whole local/CI gap - the production code is not
involved.

Guarded with the idiom planning.test.mjs:4187 already uses for its own
mode-bit arm:

skip: typeof process.getuid === 'function' && process.getuid() === 0 ? 'root bypasses mode bits' : false,

Verified by reproduction rather than by assumption, using a user namespace to
get a real uid 0:

• unshare -r node --test cadence-core/bin/phase-plans.test.mjs before the
  change: 27 tests, 3 fail - the same three, by name, that CI reports.
• After the change: 27 tests, 0 fail, 3 skipped with # SKIP root bypasses mode bits.
• node cadence-core/bin/test.mjs routing exits 0 both as the ordinary user and
  under unshare -r; tsc -p tsconfig.ci.json exits 0.
• risk-check run on the range: no category matched, not inconclusive.

The arms still run for every non-root developer and in any non-root runner.

`node-test (routing, 22)` and `(routing, 24)` have been red on `main` since the runner started executing as root. Three tests in `cadence-core/bin/phase-plans.test.mjs` `chmod` a fixture to `0o000` and assert that the unreadable plan or archive directory is skipped: - `an unreadable plan does the same: no path, one warning, clean below found` - `the by-path reader carries the out-of-grammar and unreadable arms too` - `an unreadable archive directory is skipped, never a throw` Root ignores mode bits, so on the runner the fixtures read back fine, the "unreadable" plan parses, and all three assertions fail. Every local non-root run is green, which is the whole local/CI gap - the production code is not involved. Guarded with the idiom `planning.test.mjs:4187` already uses for its own mode-bit arm: ```js skip: typeof process.getuid === 'function' && process.getuid() === 0 ? 'root bypasses mode bits' : false, ``` Verified by reproduction rather than by assumption, using a user namespace to get a real uid 0: - `unshare -r node --test cadence-core/bin/phase-plans.test.mjs` before the change: 27 tests, 3 fail - the same three, by name, that CI reports. - After the change: 27 tests, 0 fail, 3 skipped with `# SKIP root bypasses mode bits`. - `node cadence-core/bin/test.mjs routing` exits 0 both as the ordinary user and under `unshare -r`; `tsc -p tsconfig.ci.json` exits 0. - `risk-check run` on the range: no category matched, not inconclusive. The arms still run for every non-root developer and in any non-root runner.

john added 1 commit 2026-08-22 14:34:00 +00:00

test: skip the mode-bit arms when the runner is root ... 8fdfb6d4a8

The three chmod-0o000 tests in phase-plans.test.mjs assert that an
unreadable plan or archive directory is skipped. Root ignores mode bits, so
on a CI runner executing as root the fixtures read back fine and all three
assertions fail - node-test (routing, 22) and (routing, 24) have been red
since the runner moved to root, while every local non-root run is green.

Guard them with the idiom planning.test.mjs already uses for its own
mode-bit arm: skip when getuid() is 0, with the reason said out loud.

john merged commit 1497b9c6bf into main 2026-08-22 14:49:03 +00:00

john referenced this pull request from a commit 2026-08-22 14:49:05 +00:00

Merge pull request 'test: skip the mode-bit arms when the runner is root' (#228) from fix/ci-root-mode-bits into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

already-shipped

Capability was already present in the shipped code when triaged; no work needed

  

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

external-review

Raised by an outside code review; body carries the adjudication

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

in progress

  

invalid

This doesn't seem right

  

needs-decision

Deliberate keep/cut call before any code

  

proposal

Make the case for a change before writing the code

  

question

Further information is requested

  

security

Hardening: a control that fails silently or an exposure surface

  

wontfix

This will not be worked on

No labels

already-shipped

bug

documentation

duplicate

enhancement

external-review

good first issue

help wanted

in progress

invalid

needs-decision

proposal

question

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: crenshawdev/cadence-archived#228

No description provided.