Close #233: two stale self-description claims #240

Merged

john merged 3 commits from cadence/v3.6.1 into main

2026-08-23 18:41:03 +00:00

john commented

2026-08-23 18:40:58 +00:00

Owner

self-verify.test.mjs's check-10 comment carried a rationale self-verify.mjs retracted. workflows/ and references/ are in scope for the same reason and by the same mechanism, a relative-path compare with the separator appended. A skill is out of scope because it is neither directory.

One detail in the issue did not hold: cad-plan-checker does have a low rung, and DESIGN's next bullet already names it. The fix is narrower than the issue asked for and says so.

self-verify clean, 163 tests pass, risk-check over the range returned no matches.

Closes #233.

DESIGN.md illustrated runtime effort escalation with variant agent files named planner-high/planner-low. Neither is on disk and neither ever was: cad-planner's ladder is high/xhigh/max, and six roles carry rung files rather than four. The dated decision text stays; the correction is appended and points at RUNG_FILES. self-verify.test.mjs's check-10 comment carried a rationale self-verify.mjs retracted. workflows/ and references/ are in scope for the same reason and by the same mechanism, a relative-path compare with the separator appended. A skill is out of scope because it is neither directory. One detail in the issue did not hold: cad-plan-checker does have a low rung, and DESIGN's next bullet already names it. The fix is narrower than the issue asked for and says so. self-verify clean, 163 tests pass, risk-check over the range returned no matches. Closes #233.

john added 3 commits

2026-08-23 18:40:59 +00:00

docs: DESIGN named two planner rung files that never existed 7ed733782d

The 2026-07-10 routing decision illustrated rung files as planner-high/planner-low. Neither is on disk and neither ever was. cad-planner's ladder is high/xhigh/max, and six roles carry rung files, not four. RUNG_FILES in lib/rung-agent.mjs is the frozen statement of what is actually there, so the note points at it rather than restating the table.

The decision text stays as written and the correction is appended: the block is a dated record, not a description of the current tree.

Part of #233.

docs: check 10's test carried a rationale the implementation retracted e70e098fe7

The comment said skills, agents and templates carry no dispatch instructions of their own, and that references/ was in scope only because no other check reached it. self-verify.mjs says the opposite at WORKFLOWS_DIR / REFERENCES_DIR: the two directories are in scope for the same reason and by the same mechanism, a relative-path compare with the separator appended.

The test now states the real rule. A skill is out of scope because it is neither directory, which is a fact about the compare and not a claim about what a skill contains.

163 tests pass. Part of #233.

docs: task record stale-self-description-233

test / node-test (git, 22) (pull_request) Successful in 35s

Details

test / node-test (git, 24) (pull_request) Successful in 31s

Details

test / node-test (other, 22) (pull_request) Failing after 1m24s

Details

test / node-test (other, 24) (pull_request) Failing after 1m15s

Details

test / node-test (planning, 22) (pull_request) Successful in 1m40s

Details

test / node-test (planning, 24) (pull_request) Successful in 1m39s