fix(decision-review): ground the decision's own claims when refutation returns nothing #60
No reviewers
Labels
No labels
already-shipped
bug
documentation
duplicate
enhancement
good first issue
help wanted
in progress
invalid
needs-decision
proposal
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: crenshawdev/cadence#60
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/decision-review-grounding"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes a gap recorded as a CAPTURE seed from the phase 3/4 dogfood.
The defect
decision-review.md's adjudicate step required grounding at least one library/API claim against Context7 and at least one factual claim against the codebase, but scoped grounding to the objectionsrefutereturned. On a clean pass there are no objections, so the guarantee went unreachable exactly when the result was most flattering, and the run reported a bare "no findings" that reads identically to a review that never ran.That is the same silent-pass class the review subsystem is otherwise careful about: a reviewer that could not run never silently passes a gate, a dropped reviewer emits a visible reason, a risk pre-filter must note each drop. The clean-pass path was the hole.
The fix
The grounding requirement retargets instead of lapsing. With zero objections it grounds the decision's own load-bearing claims, the assertions in its statement and
Evidence:clause that would invalidate it if false, and reports eachconfirmedorcontradictedwith its citation. Acontradictedclaim rulessurvivesand gets an amendment, since it is a finding the refutation missed.The
presentstep and success criteria were updated to match, plus the skill's summary so the two do not drift.Budgets
Both surfaces sat at exactly their byte budget, so any addition overran
self-verify. The first draft was trimmed by 725B before concluding the remaining ~950B was the substance of the fix; those two entries were then regenerated per the policy stated inweight-budgets.json("regenerate fromweight.mjswhen intentional surface growth is accepted").Verification
self-verifygreentsc -p tsconfig.ci.jsonclean